Try / OpenGothic

Reimplementation of Gothic 2 Notr
MIT License
1.17k stars 85 forks source link

Fix monster damage #599

Closed thokkat closed 7 months ago

thokkat commented 8 months ago

Fix a regression introduced in https://github.com/Try/OpenGothic/commit/b1f1b83b158d681771bfcb2bb1d8882bb4ebc33b. Change from < to <= in if(src.hitchance[tal]<=critChance) accidently made monster damage non critical.

I took this opportunity to check monsters with a weapon and it seems they only do critical hits as well. If Npc_SetToFightMode is used in instance script like for goblins weapon damage is not considered. But skeletons have EquipItem instead which has makes damage include weapon damage.

Try commented 7 months ago

Merged, thanks!