Try / Tempest

API abstraction layer for 3D graphics, UI and sound. Written in C++17 with Vulkan, DX12 and Metal support.
MIT License
86 stars 25 forks source link

Vulkan compile error on linux #10

Closed vic-ju closed 4 years ago

vic-ju commented 4 years ago

The UniqueHandle class in Vulkan.hpp is not declared, because of the definition add_definitions(-DVULKAN_HPP_NO_SMART_HANDLE), but will be used later (line 13075).

I fixed it by just adding the definition add_definitions(-DVULKAN_HPP_DISABLE_IMPLICIT_RESULT_VALUE_CAST) to skip the code. Not sure if that's okay, though.

I'm using the vulkan-headers 1.2.137-1.

Try commented 4 years ago

Hi, @vic-ju !

You change in principle is fine, but I prefer for this kind of case just remove includes of vulkan.hpp in favor of *.h, because engine uses only plain "C" api from vulkan without any wrappers.