Try / Tempest

3d graphics engine
MIT License
83 stars 24 forks source link

-dx12 seems to be broken #50

Open dreimer1986 opened 1 year ago

dreimer1986 commented 1 year ago

Starting a new game or loading a save with -dx12 causes loading to take about three minutes. Then it force closes with:

---crashlog(ExceptionFilter)--- GPU: NVIDIA GeForce RTX 2080 0x00007ff77f01c857: [unknown function] in [unknown module] 0x00007ff77f01c95b: [unknown function] in [unknown module] 0x00007ff77f01cb38: [unknown function] in [unknown module] 0x00007fff83db5dcc: UnhandledExceptionFilter in C:\Windows\System32\KERNELBASE.dll 0x00007fff8677859d: RtlMoveMemory in C:\Windows\SYSTEM32\ntdll.dll 0x00007fff8675f047: _C_specific_handler in C:\Windows\SYSTEM32\ntdll.dll 0x00007fff86773e1f: _chkstk in C:\Windows\SYSTEM32\ntdll.dll 0x00007fff866eeae6: RtlFindCharInUnicodeString in C:\Windows\SYSTEM32\ntdll.dll 0x00007fff86724af5: RtlRaiseException in C:\Windows\SYSTEM32\ntdll.dll 0x00007fff83cefb1c: RaiseException in C:\Windows\System32\KERNELBASE.dll 0x00007fff78106720: CxxThrowException in C:\Windows\SYSTEM32\VCRUNTIME140.dll 0x00007fff1b02a998: stbtt_MakeGlyphBitmapSubpixel in C:\Users\Daniel\Desktop\opengothic_win\Tempest.dll 0x00007fff1b03710d: stbtt_MakeGlyphBitmapSubpixel in C:\Users\Daniel\Desktop\opengothic_win\Tempest.dll 0x00007fff1b0378cf: stbtt_MakeGlyphBitmapSubpixel in C:\Users\Daniel\Desktop\opengothic_win\Tempest.dll 0x00007fff1b030fda: stbtt_MakeGlyphBitmapSubpixel in C:\Users\Daniel\Desktop\opengothic_win\Tempest.dll 0x00007fff1b0b749a: stbtt_MakeGlyphBitmapSubpixel in C:\Users\Daniel\Desktop\opengothic_win\Tempest.dll 0x00007fff1b0b752d: stbtt_MakeGlyphBitmapSubpixel in C:\Users\Daniel\Desktop\opengothic_win\Tempest.dll 0x00007ff77ef7d1bb: [unknown function] in [unknown module] 0x00007ff77ef7c360: [unknown function] in [unknown module] 0x00007ff77ef7c5ae: [unknown function] in [unknown module] 0x00007ff77efa5368: [unknown function] in [unknown module] 0x00007fff1b0cb46f: stbtt_MakeGlyphBitmapSubpixel in C:\Users\Daniel\Desktop\opengothic_win\Tempest.dll 0x00007fff1b0cb28b: stbtt_MakeGlyphBitmapSubpixel in C:\Users\Daniel\Desktop\opengothic_win\Tempest.dll 0x00007ff77ef994e5: [unknown function] in [unknown module] 0x00007ff77f36310c: [unknown function] in [unknown module] 0x00007fff84ef244d: BaseThreadInitThunk in C:\Windows\System32\KERNEL32.DLL 0x00007fff8672df78: RtlUserThreadStart in C:\Windows\SYSTEM32\ntdll.dll

P.S. Are the WIP Windows builds MSVC2022 Debug or Release builds? These logs look a bit spartanic to me.

Try commented 1 year ago

Hi @dreimer1986 !

Thanks for report. Apparently newly introduced shadow_resolve pass doesn't compile for DX - looking into it

Try commented 1 year ago

7dbd988 - fixes crash on my machine. Please don't close ticket, as I need to develop proper solution + add unit test

dreimer1986 commented 1 year ago

Confirmed. Crash is fixed. Loading times are quite a bit longer though..

Try commented 1 year ago

Loading times are quite a bit longer though..

This is probably not related to fix - load time become slower, for the sake of mesh-optimization in 37f7ac68eda50734240b4d96636570adae953604 :D

dreimer1986 commented 1 year ago

Naaah, these loading times already were before the fix. Only the crash be gone now is new. As expected ^^

Try commented 1 year ago

related: https://github.com/KhronosGroup/SPIRV-Cross/issues/1987

Need to implement masking for DX and probably for metal as well