search

Try2Code / cdo-bindings

Ruby/Python bindings for CDO
99 stars 37 forks source link

New release on PyPI #30

Closed pgierz closed 3 years ago

pgierz commented 4 years ago

Hello,

I noticed that the version on PyPI is not up to date with the GitHub version. Can we update this please?

Thanks! Paul

Try2Code commented 3 years ago

hi @pgierz pip hast version 1.5.3 - whats missing?

the development version is not ready because I still want to change things.

pgierz commented 3 years ago

In particular this bit: https://github.com/Try2Code/cdo-bindings/blob/a4e9a8a1dc63ca9e2ac89ae8312c76d0af54dd48/python/cdo.py#L146

One of our supercomputers has the annoying habit of setting the env variable CDO=True (don't ask me why) which isn't a path, and anything without setting env specifically when creating a CDO object breaks.... so I need to patch in this change here to all of my students installations.

I know it's only one little line, but would it be a big effort to make 1.5.4 with that change?

pgierz commented 3 years ago

This is actually causing me some problems in downstream tools, since I now can't upload a working version to PyPI:

HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
122
Invalid value for requires_dist. Error: Can't have direct dependency: 'cdo @ git+https://github.com/Try2Code/cdo-bindings#egg=pkg&subdirectory=python'
Try2Code commented 3 years ago

1.5.4 has just been released with your changeset @pgierz

pgierz commented 3 years ago

Thanks!! My downstream stuff works now 😄