Korean Romanization is Wrong - Githubissues

TryGhost / Ghost

Independent technology for modern publishing, memberships, subscriptions and newsletters.

https://ghost.org

MIT License

46.86k stars 10.2k forks source link

Korean Romanization is Wrong #19907

Open anaclumos opened 6 months ago

anaclumos commented 6 months ago

Issue Summary

ㅊ should be romanized to "ch", but it's romanized to "c"

Steps to Reproduce

Create New Post
Use "ㅊ" somewhere in the title
Open right panel, look for the sluggified URL
ㅊ should be romanized to "ch", but it's romanized to "c"

Ghost Version

Ghost(Pro)

Node.js Version

Ghost(Pro)

How did you install Ghost?

Ghost(Pro)

Database type

MySQL 5.7

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

[X] I agree to be friendly and polite to people in this repository

anaclumos commented 6 months ago

I am willing to fix the error (if we can pinpoint the source of error)

anaclumos commented 6 months ago

Also, why don't we just allow UTF-8 slugs?

anaclumos commented 6 months ago

https://github.com/TryGhost/SDK/blob/244a9625f2358d52fc095570ff2722a69554c9ea/packages/string/lib/slugify.js#L1

Seems like it's coming from here?