mail.from not respected for send-magic-link endpoint

TryGhost / Ghost

Independent technology for modern publishing, memberships, subscriptions and newsletters.

https://ghost.org

MIT License

46.21k stars 10.1k forks source link

mail.from not respected for send-magic-link endpoint #20381

Open thebalaa opened 3 weeks ago

thebalaa commented 3 weeks ago

Issue Summary

setting mail.from is not respected for user registration (via send-magic-link)

Steps to Reproduce

deploy ghost with docker compose, specify mail config options and mail.from notice mails fail to send when smtp provider requires sender identify verification

Ghost Version

5.85.0

Node.js Version

18.20.3

How did you install Ghost?

docker compose

Database type

MySQL 5.7

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

[X] I agree to be friendly and polite to people in this repository

thebalaa commented 3 weeks ago

Relevant unsuccessful fix: https://github.com/TryGhost/Ghost/issues/12802#issuecomment-1917323529

thebalaa commented 3 weeks ago

Issue seems to be that the support email is set automatically to noreply@domain but it should probably be populated by mail.from if set

cmraible commented 1 hour ago

Hi @thebalaa, thanks for reporting! Can you please clarify something for me:

Is the issue that the magic link email is sent from an address different than the mail.from configured value, or is the issue that the email fails to send if the SMTP provider requires sender identity verification?

github-actions[bot] commented 1 hour ago

Note from our bot: The needs:info label has been added to this issue. Updating your original issue with more details is great, but won't notify us, so please make sure you leave a comment so that we can see when you've updated us.

thebalaa commented 55 minutes ago

Yes, the issue is that magic link email is not sent from the address specific by mail.from.