editor shortcuts collision on firefox

johnHackworth commented 3 weeks ago

Issue Summary

The shortcut to convert the selected text to a quote (ctrl+Q) doesn't work on firefox (130.0) because it's already used by the browser (to close all the windows) and can't be overtaken by a site.

Steps to Reproduce

Edit a post with Firefox 130.0
Write a text & select it
Press Ctrl+Q

Ghost Version

5.94.1

Node.js Version

18.20.0

How did you install Ghost?

using ghost-cli

Database type

MySQL 5.7

Browser & OS version

Firefox 130.0 on Ubuntu 22.04.4

Relevant log / error output

imagen

Code of Conduct

[X] I agree to be friendly and polite to people in this repository

sagzy commented 3 weeks ago

Hey johnHackworth, thanks for raising the issue 🙏

suryatejess commented 3 weeks ago

I suggest redefining the shortcut to Ctrl+Shift+Q to avoid conflicts with the existing Firefox shortcut (Ctrl+Q). I’d like to work on this issue and implement the change.

Thank you!

markstos commented 3 weeks ago

Ctrl+Shift+Q seems like a logical alternative. There are other shortcuts that use the Control+Shift prefix.

TryGhost / Ghost