Add validation on blog logo

TryGhost / Ghost

Independent technology for modern publishing, memberships, subscriptions and newsletters.

https://ghost.org

MIT License

46.92k stars 10.21k forks source link

Add validation on blog logo #3517

Closed ghost closed 8 years ago

ghost commented 10 years ago

Summary of Issue

This is not really a bug but more of a feature request. When adding a blog logo via URL there is no validation that what is being added is some sort of image. http://www.google.com is accpeted which results in the broken image icon.

Additional Information

Client OS: Mac OS X 10.9.4 Server OS: Mac OS X 10.9.4 Node Version: v0.10.21 Ghost Build Number: 0.5.0 rc1 Latest Commit: Ghost Database: SQLite3 Browser: Chrome 36.0.1985.125

felixrieseberg commented 10 years ago

Makes a lot of sense. I can take a crack at it.

felixrieseberg commented 10 years ago

Okay, so I played around with it and decided that the best course of action would be to take the given url, try to put in an img tag and catch the load/error events to see if it's something we can work with. There are open questions though:

What's the ideal behavior if we can't validate?
- Close modal and display error
- Keep modal open & find a way to display error inside modal (where?)
- Don't close modal, display error & be fine with the fact that it's behind the grey overlay

We should figure that out first. Ping @JohnONolan :)

ErisDS commented 10 years ago

I believe this and #3009 are somewhat related - I think it's intended to revisit the image upload flow on the settings screens in the future and come up with better UX for this @JohnONolan?

ErisDS commented 8 years ago

We're going to be revisiting all of the image uploading UX somewhere in the near future, so closing these two issues (#3009, #3517) in favour of an overhaul.