search

TryGhost / Ghost

Independent technology for modern publishing, memberships, subscriptions and newsletters.
https://ghost.org
MIT License
47.15k stars 10.26k forks source link

Enable Public API labs flag by default #8601

Closed JohnONolan closed 7 years ago

JohnONolan commented 7 years ago

Casper 2.0 has some features which depend on the {{#get}} helper, which needs the Public API flag to be enabled in order to work. I think it might make sense for 1.0 to take the next step of moving the Public API flag to being checked-by-default in /ghost/settings/labs/ ?

A secondary issue to this is that it would be really good to rename the file which is injected into {{ghost_head}} - currently ghost-url.js to something that makes a bit more sense, like ghost-api.js or ghost-sdk.js.

However the latte issue may be better suited to post-1.0?

JohnONolan commented 7 years ago

Hannah on Slack:

facebook uses sdk.js - medium uses medium-sdk

So ghost-sdk.js sounds like a winner

kirrg001 commented 7 years ago

@jloh Hey 🙃 Thanks for your feedback. Could you please move your comment to #8605? Thank you!

ErisDS commented 7 years ago

I ran into an issue today with a use case that wasn't covered by my initial implementation of this.

If you import from LTS, and didn't already have the public API enabled, it will be disabled after import.

The desired behaviour is that the Public API flag be enabled in 1.0.0 unless a user manually disables it.