ES6 migrations

[vikaspotluri123]

This is something ~I plan on working on in the middle of May~ a bunch of people are helping out on! 😄

• var -> let / const
• _.includes(array) -> array.includes (dropping v4 support at the end of April makes this possible)
• _.each(array) -> array.forEach
• _.isArray(array) -> Array.isArray(array) - Only if it removes the necessity of requiring lodash in a specific file
• _.isEmpty(array) -> array.length === 0 (or !array.length)
• Remove other lodash dependencies as needed on a file-specific basis (the goal isn't to purge lodash, it's to reduce unnecessary requires of the large library)
  • In that note, use Object destructuring to import required components as needed
  • Use you might not need lodash but don't go overboard
• remove usage of var self = this (arrow functions instead)
• Use defaults (I'm not sure if this is applicable) (i.e. (a = 2, b = 2) => a + b)
• Use template literals when possible

---

Checklist:

• [ ] Arrow functions do not replace named functions
• [ ] var -> const / let
• [ ] Array.(includes / each / isEmpty / isArray) lodash usage minimized
• [ ] Template literals
• [ ] Import specific lodash modules instead of entire library

[vikaspotluri123]

@Jgriebel1990 feel free to pick something from the checklist and let us know! I'll probably update the list w/ a more in depth status next week

[ashish-r]

Hi, What's the status. I would like to contribute too.

[naz]

Hey @ashish-r , the honest answer is "you would need to check yourself" :smile: Most of the codebase seems to have been updated, but as @kirrg001 pointed out earlier the data/ folder hasn't been touched, also see that parts of models/ are still on older syntax.

I would suggest updating the list on top first, and then approaching it one piece at a time, so it's easy and fast to merge.

[vikaspotluri123]

Updated list:

• Removed current assignments

• Removed items that have been migrated

• [ ] helpers (@vikaspotluri123)
• [ ] apps (verify)
  • [ ] /amp
  • [ ] /amp/lib/helpers
  • [ ] /amp/lib
  • [ ] /amp/lib/views
  • [ ] /private-blogging
  • [ ] /private-blogging/lib/helpers
  • [ ] /private-blogging/lib
  • [ ] /private-blogging/lib/views
  • [ ] /subscribers
• [ ] adapters
  • [ ] /scheduling
  • [ ] /scheduling/post-scheduling
  • [ ] /storage
• [ ] config
  • [ ] /env
  • [ ] lib
  • [ ] /fs
  • [ ] /fs/package-json
  • [ ] /image
  • [ ] /mobiledoc/atoms
  • [ ] /mobiledoc/cards
  • [ ] /mobiledoc/converters
  • [ ] /mobiledoc
  • [ ] /promise
  • [ ] /security
  • [ ] /social
  • [ ] data
  • [ ] /db
  • [ ] /export
  • [ ] /importer/handlers
  • [ ] /importer/importers/data
  • [ ] /importer/importers
  • [ ] /importer
  • [ ] /meta
  • [ ] /migrations/hooks/init
  • [ ] /migrations/hooks/migrate
  • [ ] /migrations/init
  • [ ] /migrations/versions/*/
  • [ ] /schema
  • [ ] /schema/clients
  • [ ] /schema/fixtures
  • [ ] /validation
  • [ ] /xml/sitemap
• [ ] models
  • [ ] /base
  • [ ] /plugins
  • [ ] /relations
  • [ ] services
  • [ ] /apps
  • [ ] /auth
  • [ ] /channels
  • [ ] /mail
  • [ ] /mail/templates
  • [ ] /mail/templates/raw
  • [ ] /permissions
  • [ ] /route
  • [ ] /rss
  • [ ] /settings
  • [ ] /themes
  • [ ] /themes/config
  • [ ] /url
  • [ ] translations
  • [ ] views
  • [ ] Tests
  • [ ] Root files

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[vikaspotluri123]

Not stale

[ErisDS]

Always really happy to accept PRs that ES6ify the code at any point, but don't think it needs the issue - file structure changes a lot and I think this possibly makes it seem harder?