TryGhost / Lyra

A paid-members theme for Ghost
https://lyra.ghost.io
MIT License
178 stars 109 forks source link

Don't use menu ARIA roles in site navigation. #73

Closed ndarilek closed 4 years ago

ndarilek commented 4 years ago
  1. These were inconsistently applied, and weren't used on all nav items. I.e. the navigationsite navigation items had them, but not the login/signup links.
  2. They're only intended for things that behave like menubars/dropdown menus (I.e. are navigable by up/down arrows, as commonly found in applications.)

As a screen reader user myself, this ARIA markup actually made the navbars less accessible, so I've removed them in my own site. But I'd suggest that this be merged, as it is an incorrect use of these roles.

minimaluminium commented 4 years ago

Thanks for that!