TryGhost / NQL

MIT License
4 stars 8 forks source link

Added support for null checks in relations (mongo-knex) #50

Closed SimonBackx closed 2 years ago

SimonBackx commented 2 years ago

refs https://github.com/TryGhost/Team/issues/2160

For checking if a relation is null, we need these changes. Support for setting the join type to 'leftJoin' in the config of relations for optional relations Properly handle 'null' values in relation queries

codecov-commenter commented 2 years ago

Codecov Report

Base: 78.33% // Head: 78.37% // Increases project coverage by +0.04% :tada:

Coverage data is based on head (a762075) compared to base (ff12bff). Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ========================================== + Coverage 78.33% 78.37% +0.04% ========================================== Files 4 4 Lines 1463 1466 +3 Branches 290 291 +1 ========================================== + Hits 1146 1149 +3 Misses 312 312 Partials 5 5 ``` | [Impacted Files](https://codecov.io/gh/TryGhost/NQL/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TryGhost) | Coverage Δ | | |---|---|---| | [packages/mongo-knex/lib/convertor.js](https://codecov.io/gh/TryGhost/NQL/pull/50/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TryGhost#diff-cGFja2FnZXMvbW9uZ28ta25leC9saWIvY29udmVydG9yLmpz) | `86.43% <83.33%> (+0.07%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TryGhost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TryGhost)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.