search

TryGhost / Source

The default theme for Ghost
https://source.ghost.io
MIT License
63 stars 127 forks source link

Improve accessibility rating #37

Closed burgyman closed 9 months ago

burgyman commented 9 months ago

Hi,

Not really an issue but since I'm not a developer and don't know how to create/submit PRs, I'm dropping it here.

I've made a couple of changes to improve the accessibility rating on Google PageSpeed Insights that maybe you could look into implementing:

added title="Subscribe" aria-label="Subscribe" in email-subscription.hbs <button class="gh-button" type="submit" title="Subscribe" aria-label="Subscribe">

added title="Menu" aria-label="Menu" in navigation.hbs <button class="gh-burger gh-icon-button" title="Menu" aria-label="Menu">

These basically improved the accessibility rating for my website homepage to 100%! I will look to do the same in other files that use <button> tags... Wanted to contribute to Ghost and improve even more the amazing Source theme :)

Best, Pedro

minimaluminium commented 9 months ago

Hey @burgyman, thanks for the feedbacks!

Your suggestions have been implemented in https://github.com/TryGhost/Source/commit/dc3e6cb5395efbb52e3463f79345b13543d47e2a, should be out with the next release.