Featured Image field is saving Zapier's hydration pointer uri, not uploading image

[hwlmatt]

Expected Behavior

Featured Image field uploads the selected image to Ghost

Actual Behavior

The Featured Image field is not uploading an image file passed to it, but rather saving the uri reference pointer (the stashFile like in this example created during a previous step's hydrator (download from external source to zapier). This results in site images being served from Zapier's stashfile url.

Steps to Reproduce

• Any Trigger
• Get a file from somewhere, say using Google Drives Find File by Name
• Pass the retrieved FILE on to Ghost's Zap and set it as the Featured Image
• Run Zap
• the url of the featured image of the newly created post will be something like: <img src="https://zapier.com/engine/hydrate/00000000/##################.../"...

Possible Cause

Cause Line 99 of create_post.js {key: 'feature_image', required: false},

is missing `type: 'file' Ghost's createPost function is not handling dehydration.

So I think this is just passing along that pointer uri as a text string.

That uri gets saved on the site's end, and loaded on the frontend as an externally hosted image. But that uri is intended to be passed and dehydrated, not as a permanent uri of a file.

Possible Fix

[ UPDATE: see comment below with links to gists. I have uploads working in a clone of this now.] Handling multiple passed files and only uploading uniques, and getting the string back from Ghost api to pass with the rest of the createPost form.

Optional: Could add a dehydrateFile method to createPost's res if you wish to make the Ghost uploaded image available to future Zap steps. Thought this doesn't seem necessary.

Sorry I couldn't be more help with a PR or something, I'm not where I can setup anything to test, etc. Happy to do a PR if the gists in my later comment look up to standards.

Reference docs

This is an example of an upload hydration/dehydration: https://github.com/codebycaleb/zapier-hydration-example/blob/master/creates/uploadFile.js

Zapier's cli docs on hydration/dehydration

[hwlmatt]

I have a version of this working in a test zap now.

All images on form: app/lib/upload_image.js (gist)

This is handling all image fields (featured_image, twitter_image, and og_image) and only uploading unique files. It uses the same upload response for fields sharing the same file pointer (Zapier "stash file"). Added this file to /lib/, and made create_post() async. The edited create_post() is on the same gist here.

It basically does the following:

• sorts out unique files to upload
• uploads each one at a time
• converts url response from Ghost to relative __GHOST__ url
• assigns those urls to the fields

From there the create_post() operates as is.

Happy to PR if it meets the coding standards/requirements, etc.

ONLY featured_image upload: app/lib/upload_featured_image.js (gist)

This is where I started on this. Just handles the feature_image upload. Added this file to /lib/, and made create_post() async. The edited create_post() is on the same gist here.

[naz]

Hey @hwlmatt the PR where we could discuss and see the differences would be much appreciated. Some comments on the approach you've taken:

• the upload_images.js file looks like something that should be done through the Admin SDK rather than in Zapier integration itself 🤔
• to avoid the zapier stored shash file I think the dehidration you've proposed would be a much cleaner solution
• there is no need to convert the image url back and forth - the idea is that the client should be able to operate without knowing about __GHOSTURL__ existence
• you can hit the uploads endpoints all at once, it's not like a hundred uploads goes out all at once - it is only three of them. but don't mind leaving this optimization in place

There have not been reports about this issue ever since the initial report. I'll close it out for now and very happy to reopen and let @royalfig to give a hand if there's interest in fixing this bug.