TryGhost / Zapier

Ghost <-> Zapier Integration
https://developer.zapier.com/app/1566
MIT License
5 stars 3 forks source link

Newsletters feature for Ghost 5.0 #60

Closed sam-lord closed 2 years ago

sam-lord commented 2 years ago

Added the newsletter feature for Ghost 5.0.

In the form, a new dropdown allows the user to select either single or multiple newsletter mode. Single newsletter mode uses the original "subscribed" boolean, and multiple newsletter mode includes a dropdown to select the newsletters.

sam-lord commented 2 years ago

Thanks for the review. Before merging I wanted to respond to these :)

The resources type looks really useful, I think if we do a breaking change at some point it would be good to replace those triggers that are only used for dynamic dropdowns. Hadn't considered at the time of writing these since I wanted the changes to be as low-impact and blend in as much as possible.

Extra fields warning is a little annoyance, it appears if you go through the process of making a Zap using the "single newsletter" mode then change to multiple newsletters, or vice versa. Fortunately it doesn't matter whether the user clicks to remove the extra fields, the Zap will still work. I wonder if there's a hack we can do to make Zapier think we're using every field -- looping over them to make a hash or something 😂