search

TryGhost / docs

Ghost's official documentation
https://docs.ghost.org
MIT License
112 stars 79 forks source link

Added cloning command for Ghost-Admin #32

Closed no-subterfuge closed 5 years ago

no-subterfuge commented 5 years ago

Hello, I may be misunderstanding something here, but in the way I see how git works, we're still in the Ghost git project in the core/client dir, whereas we need to do changes on the Ghost-Admin project. A new project must be initialized - or Ghost-Admin must be cloned - in here so changes for the remotes will be made for this specific dir and not for the Ghost one

I tried the two solutions, mine works whereas I have issues with yours (pulling Ghost-Admin directly)

As it is my first PR, I'd be pleased if you tell me if I'm doing something wrong or if I'm missing something Have a nice programming time

JohnONolan commented 5 years ago

Deploy preview for tryghost ready!

Built with commit 1c96ceeb120059c8b611b6e99b9c7acedf096478

https://deploy-preview-32--tryghost.netlify.com

JohnONolan commented 5 years ago

Thanks for the PR! Ghost-Admin is a sub module of the parent Ghost repo, so it’s cloned automatically - there’s no need to manually do it. You just have to set the upstream reference to your own fork if you want to push there :)

no-subterfuge commented 5 years ago

Oh ok, I see Thanks for the clarification ! :D

no-subterfuge commented 5 years ago

Excuse me again, I have retried your solution, I still think it will not work with a fresh install of git without any specific config.

As said in this thread, the argument --recurse-submodules may be missing while cloning Ghost. Without this, the submodules (including Ghost-Admin) aren't automatically cloned.

With your wiki, the changes for the remotes applied under core/client take effect for Ghost, not for the submodule Ghost-Admin. Here's a picture to explain what I mean : Screenshot_20181121_164928.png I have tried with git clone --recurse-submodules git@github.com:TryGhost/Ghost and this works perfectly (well, without the recent changes on the wiki).

Your solution may seems to work because you're pulling Ghost-Admin after changing the remotes, but later, if you want to push your commits, you will have issues.

I would be more than happy to change my commit for this PR, but I don't know how to do that. May I create another PR ?

Thank you for your time and sorry if I'm not clear.

JohnONolan commented 5 years ago

If you follow the install guide you'll see the step to correctly update submodule references: https://docs.ghost.org/install/source/#properly-rename-your-references-again

no-subterfuge commented 5 years ago

Actually, that was my point: following this install guide was leading to that unwanted behavior - but I see you committed some changes to correct that ! Sorry to have been unclear, have a nice day