TryGhost / docs

Ghost's official documentation
https://docs.ghost.org
MIT License
112 stars 79 forks source link

Google Sheets embeds are too small (integrations) #50

Open kymellis opened 5 years ago

kymellis commented 5 years ago

I am working on the Integrations page for Google Sheets + Ghost, explaining how to embed a spreadsheet into a Ghost post. This is great for people who want to embed dynamic data or swipe files that their readers can export from their site.

When I published the page, the embed appears very small on the page:

google sheets embeds on docs

This is not a usable working example of this embed and should fit to the width of the content. Can we fix this?

The embed code used is:

<iframe src="https://docs.google.com/spreadsheets/d/e/2PACX-1vQKQwfka4cgU7mnS2uAiCMKs0wkmHJQdH5sc4mp231iVKjwueBVaX3Qy8no7gTihQXr6kwJ52TLyfLt/pubhtml?widget=true&amp;headers=false"></iframe>

Note: I've unpublished the Integrations page for now, but the content is in draft in Ghost Admin.

aileen commented 5 years ago

@kymellis The result looks the same to me with Casper (when I check the preview link), which doesn't make it right, but I think it's a general issue that we didn't tackle yet (and we should maybe think of opening the issue as well on Casper?)

I will assign this issue to @peterzimon as it's a design issue here.

kymellis commented 5 years ago

@AileenCGN @peterzimon OK sounds good. I already opened an issue on Casper here for the exact same problem.

I noticed that the same thing happens in Casper with some other embeds, too. But it's not always an issue because it depends on the content being embedded.

For example a Gist embed from GitHub on Casper looks like this:

screenshot 2018-12-05 at 17 40 11

This looks OK at a smaller size, but it would look better full-width.

This example already renders at the full-width on the live docs site: https://docs.ghost.org/integrations/github/

kymellis commented 5 years ago

@peterzimon

I've now published the Backtracks integration using an OEmbed and it's not displaying quite right on the docs front-end. See here, the logo on the right is squished:

screenshot 2019-01-05 at 00 15 24

Should I create a new issue for this or is it OK in here?