search

TryGhost / docs

Ghost's official documentation
https://docs.ghost.org
MIT License
112 stars 80 forks source link

Clicking search results doesn't always take you to the page #74

Open ErisDS opened 5 years ago

ErisDS commented 5 years ago

I've spotted this issue a few times when using search. Sometimes I click on a search result, and it populates the search box rather than taking me to the page. I thought it was random, but I think I have a reproduction case.

To Reproduce

  1. Navigate to a section of the Ghost CLI Knowledgebase, for example "Folder stucture"
  2. Search for something that also exists on this page, for example "second domain"
  3. Click on the "Knowledgebase" entry
  4. See that the search box is updated, but not closed

Now that I understand the reproduction case, I can see that the anchor in the URL is updated. Therefore I think the bug is actually that the modal doesn't close if only the anchor changes.