daviddarnes
commented
3 years ago Hey @Jatin794, this is a starter project designed to be modified to your needs, rather than meeting them right out of the box. However if you see an improvement that will help everyone then feel free to make a pull request 😊
Welcome to the Eleventy Starter Ghost GitHub repo! 👋🎉
We use GitHub only for bug reports 🐛
Anything else should be posted to https://forum.ghost.org 👫
For questions related to the usage of Eleventy, please check out the docs at https://www.11ty.io/docs/
🚨For support, help & questions use https://forum.ghost.org/c/help 💡For feature requests & ideas you can post and vote on https://forum.ghost.org/c/Ideas
If your issue is with Eleventy itself, please report it at the Eleventy repo ➡️ https://github.com/11ty/eleventy/issues/new/choose.
Issue Summary, To reproduce
Inappropriately sized targets: On smaller screens with the right navigation bar. Lighthouse recommends "Interactive elements like buttons and links should be large enough (48x48px), and have enough space around them, to be easy enough to tap without overlapping onto other elements".
Contrast: All screens. On a page with links the contrast with the links is not ideal, so they should be darker. This is another issue that Lighthouse points out, as "Low-contrast text is difficult or impossible for many users to read". It also recommends caching the cover image for at least a year, but 30 days seems fine enough.
Navigation Bar: All screens. Ideally, I'd want the right navigation bar to grab the items on the secondary menu of my blog instead of grabbing independently of the original layout. (In a somewhat unpredictable way.)
Explanation
With the first 2 issues resolved, the starter should have 400 Lighthouse score, as you can see from my report here (or the home here, but that's not very representative). Ideally I'd like it to cache cover images like it does for inline images (honestly, that's a feature which makes me prefer this starter over any other, and it seems the image plugin now has processing built-in).
About the secondary navbar, I'd prefer it to be predictable and under control from the upstream navigation settings.
Technical details: