TryGhost / express-hbs

Express handlebars template engine with inheritance, partials, i18n and async helpers.
MIT License
459 stars 77 forks source link

Conflict between content blocks #100

Closed penx closed 5 years ago

penx commented 8 years ago

If two content blocks share the same name, or a content block on a page could contain request sensitive information, then the incorrect html content could be served to a user if the server is processing 2 separate requests asynchronously.

e.g.

jtwebman commented 6 years ago

I created a test for this in PR #148. It doesn't seem to be an issue but maybe my test isn't tested what you are saying @penx. Let me know.

jtwebman commented 6 years ago

Ok after thinking about it more I think I have a failing test now See https://github.com/barc/express-hbs/pull/148 @penx let me see if this can be fixed without much changing.

jtwebman commented 6 years ago

@penx Figured it all out I think please take a look at my PR #149 to see if this fixes your issues as well.