TryGhost / express-hbs

Express handlebars template engine with inheritance, partials, i18n and async helpers.
MIT License
458 stars 76 forks source link

Remove heavy dependencies #198

Closed jafl closed 4 years ago

jafl commented 4 years ago

lodash is 4.9M, and bluebird is 708K

This PR removes the dependency on bluebird and switches to require individual components from lodash, thereby reducing the size of the node_modules folder.

ErisDS commented 4 years ago

Not sure if this is actually meant to be a PR to us or if it was meant to be private - I see a mention of private versions?

If it is a request for us to merge changes, then please update to include explanations & ideally keep unrelated changes in separate PRs. Remember you're trying to sell code changes to people who maintain 100s of repos, we don't necessarily have any context loaded 🙂

jafl commented 4 years ago

Probably not worth it.