TryGhost / gscan

Ghost theme scanner - checks for errors and feature support
https://gscan.ghost.org
MIT License
75 stars 56 forks source link

Potentially misleading warning for {{ @labs.members }} #396

Open SingingTree opened 3 years ago

SingingTree commented 3 years ago

https://github.com/TryGhost/gscan/pull/373 added a warning for {{ @labs.members }} usage. The warning states

The {{@labs.members}} helper will always return true in Ghost v4 and will be removed from Ghost v5, at which point it will return null and evaluate to false.Find more information about the @labs property here.

However, the current docs state

The existing {{@labs.members}} flag will return true by default, and false if the Subscription access setting is set to Nobody.

Which appears to be correct in testing.

It sounds like the intention is still to remove the helper and replace it with something else. Until the replacement exists, {{ @labs.members }} seems one of the better ways to conditionally show things like subscribe buttons. Is there any value in changing the warning to reflect the correct functionality of the helper, whilst retaining the deprecation warning (assuming the helper is still being deprecated)?