search

TryGhost / gscan

Ghost theme scanner - checks for errors and feature support
https://gscan.ghost.org
MIT License
75 stars 56 forks source link

@partial-block #417

Closed IamTheLime closed 2 years ago

IamTheLime commented 2 years ago

Handlebars {{ @partial-block }} is broken in the latest version of ghost, gscan is identifying this helper as a handlebars error.

Downgrading gscan, in the docker container will allow you to load the website without loss of functionality.

benshaaw commented 2 years ago

We have confirmed that this breaking change happens in-between gscan versions 4.1.0 and 4.1.1, tested on a local ghost:4-alpine container and rebuilding the node_modules dir after changing gscan version pins.

benshaaw commented 2 years ago

~We believe it may be related to changing a call from getNodeName to getPartialName in this diff, but yet to confirm.~

EDIT: Not quite the case, fix was located in the ast-linter/base.js file

benshaaw commented 2 years ago

418

Theme validating successfully with changes shown in this PR

tpatel commented 2 years ago

I've made a minor change to https://github.com/TryGhost/gscan/pull/418 and pushed it, thanks for your contribution @benshaaw.

This is released in gscan v4.16.1, and I'll merge that in Ghost for the next release.

tpatel commented 2 years ago

This was released in Ghost v4.28.0 https://github.com/TryGhost/Ghost/releases/tag/v4.28.0