search

TryGhost / gscan

Ghost theme scanner - checks for errors and feature support
https://gscan.ghost.org
MIT License
75 stars 55 forks source link

Gscan does not detect custom setting usage inside a get helper #464

Open truekasun opened 1 year ago

truekasun commented 1 year ago

gscan result on Ghost image

featured.hbs image

package.json image

Note: The expected functionality (Tags filtered from the slugs inside the custom setting) is working fine. But it throws an error while validating.

ErisDS commented 1 year ago

Hey there, thank you so much for the detailed bug report.

That does look like something that shouldn't happen! A PR to fix this issue would be very welcome 🙂

unitof commented 6 months ago

@truekasun Is your featured.hbs located in your theme's partials/ directory? If so, this may actually be #523, and not have anything to do with the #get helper function.