gscan with zip file should throw an error without -z flag

[cathysarisky]

Issue Summary

Calling gscan --verbose dist/mythemefile.zip says 'Checking theme compatibility' and then exits without error.
Preferred behavior would be to throw an error/diagnostic message that gscan needs the -z flag. That would be much more newbie-friendly.

Steps to Reproduce

Run gscan with a zipfile as the argument, but without the -z flag.

I'd expect that it'd either detect that it had received a zip and process it, OR that it'd throw an error that the .zip file is not a file path.

The silent return looks too much like 'yep, this file is fine'.

Ghost Version

5.30

Node.js Version

16.15.1

How did you install Ghost?

local install/Windows

Database type

SQLite3

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

• [X] I agree to be friendly and polite to people in this repository

[ErisDS]

Yo @cathysarisky 😬

I have noticed recently when using gscan on the CLI that there are a lot of cases that aren't throwing errors. I think we might have a regression there somewhere.

I'm gonna move this issue over to the gscan repo, but I agree we should do something about it. Feel free to take a look. Also going to cc @royalfig on this one cos I agree it's a developer experience thing 👍

[cathysarisky]

Thanks @ErisDS - I didn't realize gscan had its own repo. :)

[royalfig]

This fix hasn't shipped yet, but it'll go out in the next release.

Now when you upload a zip file without the flag, you'll get an error and suggestion to try with the -z flag 🥳