search

TryGhost / gscan

Ghost theme scanner - checks for errors and feature support
https://gscan.ghost.org
MIT License
75 stars 55 forks source link

Support for Github repository. #518

Closed varadekd closed 7 months ago

varadekd commented 7 months ago

I noticed in the Readme that scanning isn't supported using the Github repository. I'm considering developing this feature. Should I follow a specific process for shipping this feature? Do I need to submit a proposal first, or can I simply build it and create a PR?

varadekd commented 7 months ago

@JohnONolan Can you help me with this issue? or tag someone who will help me with this query

JohnONolan commented 7 months ago

I'm not sure I understand what you mean. Can you explain what the feature is that you're proposing?

varadekd commented 7 months ago

Hi @JohnONolan,

Sorry for any confusion caused. I am planning to develop the functionality that allows gscan to fetch content using a Github URL. My question is, do I need to submit a written document first to propose and build this feature, or can I go ahead and start building it?

varadekd commented 7 months ago

@JohnONolan Waiting for your reply on this. I hope my comment is much clear now

JohnONolan commented 7 months ago

You mean adding a GitHub URL as an input to the web version, so people can use that rather than uploading a zip? If so, sure go for it. Feel free to submit anything in advance if you want feedback before building, otherwise happy to offer feedback on a PR

varadekd commented 7 months ago

I am closing this issue since my requirement are met.