TryGhost / gscan

Ghost theme scanner - checks for errors and feature support
https://gscan.ghost.org
MIT License
74 stars 55 forks source link

Upload files are not getting deleted. #519

Open varadekd opened 6 months ago

varadekd commented 6 months ago

If an uploaded zip file fails during the scanning phase, we do not remove it from the server storage. This can result in unnecessary space occupation, potentially filling up our server storage.

To reproduce this issue:

Expectation: This file should be deleted in case of an error since we generate a unique name for the file every time it is uploaded.

Additional Information.

  1. I zipped the gscan code for testing this feature.
  2. Machine information
    1. Machine OS: Ubuntu 22.04 LTS
    2. Node version: v18.18.0
    3. Yarn version: 1.22.21
varadekd commented 6 months ago

@JohnONolan Just wanted to confirm if this is a valid bug. If so I will fix it.

varadekd commented 5 months ago

@JohnONolan Please check the PR created for this issue

ErisDS commented 5 months ago

Hey @varadekd, thanks for the issue and PR. Would you be able to create a test to demonstrate the issue, and how the patch resolves it? Thanks!

varadekd commented 5 months ago

@ErisDS I can create a test; I just want to make sure that when you say 'create a test to demonstrate the issue,' does this refer to a prefix, a postfix, or both?

My understanding is that it involves a prefix, where we can keep track of exactly what the issue is and how this patch is resolving it.

varadekd commented 5 months ago

@ErisDS Please let me know if my understanding with respect to the requirement is correct or not