TryGhost / gscan

Ghost theme scanner - checks for errors and feature support
https://gscan.ghost.org
MIT License
75 stars 55 forks source link

GS100-NO-UNUSED-CUSTOM-THEME-SETTING ignores `/partials` directory #523

Open unitof opened 5 months ago

unitof commented 5 months ago

The "Custom theme settings defined in package.json must be used at least once in the theme templates" test explicitly ignores them files located in /partials, including /partials/content-cta.hbs.

One of the Ghost Docs examples demonstrates using custom variables to make the CTA text user-editable, but doing so on my theme is now causing it to fail validation because gscan is not seeing the CTA variables used.

Why does gscan ignore partials/*?

Should custom variables related to CTA be used somewhere other than partials/content-cta.hbs and imported?