search

TryGhost / node-sqlite3

SQLite3 bindings for Node.js
BSD 3-Clause "New" or "Revised" License
6.16k stars 809 forks source link

Database.backup() typings? #1655

Open benallfree opened 1 year ago

benallfree commented 1 year ago

Summary

Hi, I noticed there are no TS typings for Database.backup and the Backup class.

Would you like a PR for that?

https://github.com/TryGhost/node-sqlite3/blob/master/src/backup.h#L17

Proposed implementation

Add typings and wiki docs for https://github.com/TryGhost/node-sqlite3/blob/master/src/backup.h#L17

daniellockyer commented 1 year ago

A PR for this would be great 🙂

ethyaan commented 9 months ago

one year later, no changes on this this yet.

benallfree commented 9 months ago

@ethyaan Thanks for reminding me, I just made a PR for this.

benallfree commented 9 months ago

@daniellockyer Check it out please :)

ethyaan commented 9 months ago

@benallfree Thank you, and btw any hands required? just let me know.

viniciusteixeiradias commented 4 weeks ago

Why is this still open?