search

TryGhost / node-sqlite3

SQLite3 bindings for Node.js
BSD 3-Clause "New" or "Revised" License
6.23k stars 817 forks source link

bump node-gyp to v10 #1788

Open branchvincent opened 6 months ago

branchvincent commented 6 months ago

Fixes #1752

YasharF commented 5 months ago

Hey there, I am curious. What kind of tests have run to verify the version bump is not creating other issues, regressions, etc. ?

niklasf commented 5 months ago

Can confirm this solves the issue, builds, and works at least for basic database operations. Tested with --target_arch arm --build-from-source.

demiankatz commented 4 months ago

I wonder if this might also fix #1762, since the deprecated dependency is coming in courtesy of node-gyp.

gladykov commented 4 months ago

This would also fix https://github.com/advisories/GHSA-2p57-rm9w-gvfp. All dependencies are fixed down the line.

Current dependency chain to affected package:

image

netroy commented 4 months ago

I compiled this branch, and then updated n8n to use file: versions of sqlite3, and all integration tests still passed. Considering that n8n's backend tests do a lot of database calls, I don't think there is going to be any major regression caused by this upgrade. The upgrade also cleaned up the dependency tree a little bit as a side-bonus 🎉 .

@daniellockyer Can we please have this merged 🙏🏽