Open wind111-lang opened 6 months ago
Hey there, I am curious, what kind of tests have run to verify the version bump is not creating other issues, regressions, etc. ?
Hello, @YasharF. Thank you for your comment.
I have run the workflow in this PR and passed all environments with the changes in semver-check.js and BinaryBuilder.Dockerfile. Since I'm running the workflow on a fork repository, I'm not sure what the results will be on master repository Actions.
The issue was that the version checked in semver-check.js
was specified as Node 10, causing the tests to fail. Additionally, on Debian bullseye, the tests passed after temporarily setting maxsockets=1 to fix the Client network socket disconnected before secure TLS connection was established error
.
After making these changes, I ran the workflow with the updated versions from the Renovate PR, and all environments passed successfully.
Thank you.
I ran the same test suite with this branch as I did in #1788, and everything worked as expected to me.
I get it if there are hesitations to merge these PRs, but it'd be nice to have a clarity on intent here, so that people like me can decide if we should wait for these PRs to be merged, or if we create a "temporary" fork to publish on NPM under a scope.
@daniellockyer can you please shed some light on the maintenance status of this project 🙏🏽
Changed tools/semver-check.js
Node.js 10 was end-of-life on December 31, 2021. so using
process.versions.node
to always use the current Node.js version. This change solves fix GitHub Actions test failures caused by specifying Node.js '10.12.0'. node-sqlite3 testing with Node.js 18, so '10.12.0' isn’t need.Changed tools/BinaryBuilder.Dockerfile
--maxsockets=1
tonpm install
as a temporary workaround. This fixes the error:Client network socket disconnected before secure TLS connection was established
in bullseye CI test.Changed workflow CI
arm64
architecture formacos-latest
.setup-msbuild
from v1 to v2 for better Windows11 compatibility.setuptools
installation step becausenode-gyp
v10 supports Python 3.12 by default.upload-artifact
due to test failures with the latest version.Upgrade some dependencies
node-addon-api
to 8.0.0 or higher. (#1767 )tar
to 7.0.0 or higher. (#1777 )node-gyp
to 10 or higher. (#1724 )These updates improve compatibility, performance, and security of your project.