TryGhost / node-sqlite3

SQLite3 bindings for Node.js
BSD 3-Clause "New" or "Revised" License
6.23k stars 817 forks source link

[Improvements🛠️]:Update tools directory, CI workflow, and dependencies for better compatibility and performance #1790

Open wind111-lang opened 6 months ago

wind111-lang commented 6 months ago

Changed tools/semver-check.js

Node.js 10 was end-of-life on December 31, 2021. so using process.versions.node to always use the current Node.js version. This change solves fix GitHub Actions test failures caused by specifying Node.js '10.12.0'. node-sqlite3 testing with Node.js 18, so '10.12.0' isn’t need.

Changed tools/BinaryBuilder.Dockerfile

Changed workflow CI

Upgrade some dependencies

These updates improve compatibility, performance, and security of your project.

YasharF commented 5 months ago

Hey there, I am curious, what kind of tests have run to verify the version bump is not creating other issues, regressions, etc. ?

wind111-lang commented 5 months ago

Hello, @YasharF. Thank you for your comment.

I have run the workflow in this PR and passed all environments with the changes in semver-check.js and BinaryBuilder.Dockerfile. Since I'm running the workflow on a fork repository, I'm not sure what the results will be on master repository Actions.

The issue was that the version checked in semver-check.js was specified as Node 10, causing the tests to fail. Additionally, on Debian bullseye, the tests passed after temporarily setting maxsockets=1 to fix the Client network socket disconnected before secure TLS connection was established error.

After making these changes, I ran the workflow with the updated versions from the Renovate PR, and all environments passed successfully.

Thank you.

netroy commented 1 month ago

I ran the same test suite with this branch as I did in #1788, and everything worked as expected to me.

I get it if there are hesitations to merge these PRs, but it'd be nice to have a clarity on intent here, so that people like me can decide if we should wait for these PRs to be merged, or if we create a "temporary" fork to publish on NPM under a scope.

@daniellockyer can you please shed some light on the maintenance status of this project 🙏🏽