search

TryKickoff / kickoff

:basketball: A lightweight front-end framework for creating scalable, responsive sites. Version 8 has just been released!
http://trykickoff.com
MIT License
463 stars 59 forks source link

Fix SVG minification #128

Closed mrmartineau closed 7 years ago

mrmartineau commented 8 years ago

SVG minification in the next branch is currently broken. I have seen a few issues, one of which seemed to remove actual items from the compressed code. This, of course, affects the new SVG icon sprite-sheet workflow. SVGO is probably to blame for this and I will investigate the various SVGO options to see if one of them is causing the error. It could also be due to strangely formatted SVG code itself.. watch this space 👀

rentorm commented 7 years ago

Do you have more details on this issue and how could I reproduce it? Maybe you can share files which caused the issue and I could try to have a look.

mrmartineau commented 7 years ago

@rentorm I experienced a few issues where some svg paths or even groups were being removed. I have not been able to find the issue. I should find the offending SVG, the TMW logo, and add to the ticket..

mrmartineau commented 7 years ago

Turned out to be a malformed SVG source file..