search

TryQuiet / quiet

A private, p2p alternative to Slack and Discord built on Tor & IPFS
https://www.tryquiet.org
GNU General Public License v3.0
1.94k stars 85 forks source link

Fix integration tests #1153

Open siepra opened 1 year ago

siepra commented 1 year ago

See https://github.com/TryQuiet/quiet/actions/runs/3893011417

siepra commented 1 year ago

Temporarily blocked by https://github.com/TryQuiet/quiet/issues/1170

kowalski commented 1 year ago

@vinkabuki I think this is done, right?

holmesworcester commented 1 year ago

What's the status of this?

Kacper-RF commented 1 year ago

Now we have 5 working and usually stable integration tests - restart app, create-join-community, registrar, send-medium-file, send-small-file. image

Small file its about 5mb Medium file its about 20mb, also I try to send files in the 20-30MB range, but they mostly fail.(probably because of this bug)

Send messages where users are online - i think its near to be fixed but its a long debug process, already 6/8 steps are working but there are some issues with message replication steps - meanwhile i'm trying to solve this test

Sending big file its not working because of this bug with file downloading, but i already prepared big file (50mb) on S3 and CI for downalod that file on workflow, so if problem will be solved this test also should be working

holmesworcester commented 1 year ago

understood! this seems like a priority. what's the issue with message replication?

Kacper-RF commented 1 year ago

@holmesworcester I figured out what was a problem - user didn't have initial info message from general channel in his store, after advice from Bartek and Marek i changed order of event in backend package and its started working.

So now we have very simple test with owner and user, and now i'm focused to trying run tests for messages from original scenarios, which are more complex( two users and owner etc.)

image

holmesworcester commented 1 year ago

Is the problem that was happening meaningful from the user's point of view? Are there any issues we need to create for fixes in the app?

One note is that there may be things that are actually broken from the user's point of view and if anything weird is happening in the tests it might be that we are detecting things bugs!

Kacper-RF commented 1 year ago

This is more related to test cases, but is a chance that by that way of solving bugs in test we prevent bugs in future in real usage of app.

holmesworcester commented 10 months ago

@Kacper-RF is this issue still relevant, and still blocked?

It doesn't seem blocked, so I'm moving it to backlog.

Kacper-RF commented 10 months ago

As far as I remember here was some problem with the Redux Toolkit library, so I used the beta version on a branch dedicated to these tests.

It's hard to say about status, the tests haven't been updated since the backend was refactored to NestJS.

I think that the moment when it will be worth returning to this topic will be the moment when we finish things from the current and next sprints, because we have introduced some big changes, e.g. the registration flow