search

TryQuiet / quiet

A private, p2p alternative to Slack and Discord built on Tor & IPFS
https://www.tryquiet.org
GNU General Public License v3.0
1.9k stars 81 forks source link

Language is not supported (Swedish) #2302

Open matstage opened 4 months ago

matstage commented 4 months ago

Hi,

I tried to create a channel using the Swedish word for meeting (Möte). When creating the channel, I get the error message: "Name cannot begin with whitespaces or dashes"!

Replacing the ö with an o creates the channel successfully.

Quiet_Language

Version tested on are 2.1.0 and 2.1.1!

holmesworcester commented 4 months ago

Right now channel names are validated just as strictly as usernames. We don't need to do this, I don't think, so the solution would be to allow special characters in channel names.

leblowl commented 4 months ago

Also the error message is misleading here. @richardtorres314, tagging you in case you find this interesting.

richardtorres314 commented 2 weeks ago

@holmesworcester Will the same apply to community names (allowing of special characters)? What are we classifying as special characters? Lastly, we set the username to lowercase; will the same apply both community and channel names? I'll have a PR open this week for this issue. Thank you!

holmesworcester commented 5 days ago

@richardtorres314 apologies for the slow reply!

Will the same apply to community names (allowing of special characters)?

Yes. There will be no attempt at a uniqueness guarantee for community names so it makes no sense AFAICT to restrict the choice of community name.

What are we classifying as special characters?

For usernames, anything not a-z, 0-9.

Lastly, we set the username to lowercase; will the same apply both community and channel names?

The reason for enforcing all lowercase for usernames is to limit impersonation, so we do not need to do this for community and channel names since those can be duplicates.

I'll have a PR open this week for this issue. Thank you!

Thank you!