Feat/519 big emoji messages

TryQuiet / quiet

A private, p2p alternative to Slack and Discord built on Tor & IPFS

https://www.tryquiet.org

GNU General Public License v3.0

1.98k stars 86 forks source link

Feat/519 big emoji messages #2389

Closed mike-kiss closed 7 months ago

mike-kiss commented 7 months ago

Pull Request Checklist

[x] I have linked this PR to a related GitHub issue.
[x] I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

[ ] I have run e2e tests for mobile
[ ] I have updated base screenshots for visual regression tests

mike-kiss commented 7 months ago

The desktop test failures appear to be a result of the MUI auto-generated class names changing in the snapshots. I can investigate but I don't think this is actually the result of my changes - do we have a solution for this? (Edit to add: do we have control over the text colors for the snapshot diffs? I find these very hard to read)

leblowl commented 7 months ago

Thanks @mike-kiss , I think the test failures are from changing the className prop. I don't see them failing on develop. I'm not sure if there is another solution, but I have just been updating the snapshots in these cases.

leblowl commented 7 months ago

Also, I'm not sure about the color, but I agree that would be nice to change

mike-kiss commented 7 months ago

KK. Snapshots updated. Should pass now, I hope :+1:

holmesworcester commented 7 months ago

Thanks @mike-kiss!

mike-kiss commented 7 months ago

Still seeing errors on some the tests but these look like network/DNS-level issues