TryQuiet / quiet

A private, p2p alternative to Slack and Discord built on Tor & IPFS
https://www.tryquiet.org
GNU General Public License v3.0
1.97k stars 85 forks source link

Replace username registration with a simple duplicate warning #2652

Open holmesworcester opened 3 days ago

holmesworcester commented 3 days ago

Username registration has been a maintenance burden and it will not be compatible with our LFA-based, multi-admin, mutli-device plan.

Signal now warns users about duplicate usernames. This is a simple solution that will work well for us too. Let's do it, and remove existing user registration code.

We can still attempt to stop users from registering duplicate usernames and prompt them to change their names.

holmesworcester commented 2 days ago

In Signal this is a warning bar across the top of the screen in any chats with duplicate names.

jgaylor commented 2 days ago

We can do a warning bar in any chats idea. Just want to point out we've explored some other things:

  1. Here in changing username, we warn that the username is already taken: https://www.figma.com/design/CkkTkVhpCh2lPpF1mRd1vF/Change-usernames?node-id=13-20&t=NAlvxMU1YFJ1IMqd-1
  2. In a different ticket we were going to explore a 6 digit hash. https://www.figma.com/design/CkkTkVhpCh2lPpF1mRd1vF/Username-(changing%2C-displaying-dups)?node-id=2814-5322&t=NAlvxMU1YFJ1IMqd-4

Also, what's "Existing user registration code" mean. I'm trying to get the screens together to start working on this.

jgaylor commented 1 day ago

@holmesworcester I'm trying to understand the why behind this feature, and then what users are supposed to be able to do. This will help drive the design solution. Currently, i'm just making solutions based on assumption. So, besides the maintenance burden and incompatibility rationale can you provide more information on this ticket...

  1. Why is it important to signify duplicate usernames to people? Here are some that I think make sense:
  1. More importantly, Once we've indicated this somehow, what is the desired action an admin or non-admin will want to take? Here are some that I think make sense:
  1. Should user be able to dismiss this warning? If so, Is there another way to access the duplicates? What's the logic? Does it keep coming back until you take some action? What is that action?
jgaylor commented 1 day ago

Anyway, latest is here, for easy reference later: https://www.figma.com/design/CkkTkVhpCh2lPpF1mRd1vF/Username-(changing%2C-displaying%2C-duplicates)?node-id=2828-24755&t=BC07iebO4ivkPK0l-4