search

TryQuiet / quiet

A private, p2p alternative to Slack and Discord built on Tor & IPFS
https://www.tryquiet.org
GNU General Public License v3.0
1.94k stars 85 forks source link

User should be able to right click to copy image (and text) #568

Open holmesworcester opened 2 years ago

holmesworcester commented 2 years ago

Right now there's no way to get an image out of Quiet. You can't save it, You can't copy it.

Letting users right click to copy would be awesome. This looks like a reasonable way to achieve this in Electron, and it seems like it will enable copying text too: https://github.com/sindresorhus/electron-context-menu

See also https://stackoverflow.com/questions/63379503/electron-js-with-the-right-click-be-able-to-perform-a-copy-and-cut-if-a-sel

holmesworcester commented 12 months ago

Notes from a duplicate issue:

Right now you can't right click on a link or text to copy it, or right click on an image to save it, or lots of normal things.

There's a library for all of this. Let's try it to see if it's a quick fix for this set of issues and how much mileage we can get out of it!

https://github.com/sindresorhus/electron-context-menu

The options that make sense to me are:

And maybe: showSelectAll

Also I'm not sure if this gives us a way to show context menu on selected text, but if it does we should do that too.

agiledev24 commented 6 months ago

This issue is solved with my last PR - https://github.com/TryQuiet/quiet/pull/2355 @holmesworcester