search

TryQuiet / zbay

GNU General Public License v3.0
18 stars 3 forks source link

Spotted in logs: a lot of attempts to connect to onion addresses that fail. Tor at 100% cpu #827

Open kowalski opened 3 years ago

kowalski commented 3 years ago

I have plenty of messages like:

May 14 18:04:27.000 [notice] Closed 1 streams for service [scrubbed].onion for reason resolve failed. Fetch status: No more HSDir available to query.

Something in libp2p makes a lot of connections. Maybe it's our network "rembering" old peers that are now gone. It may be that our entry node has a big libp2p.addressBook with plenty of these addresses and it's telling new clients to connect to them.

If this is a case, we should see how to make that the failure of connection in WebSocketOverTor translates to removing the address from addressBook, so that our network doesn't accumulate garbage.

holmesworcester commented 3 years ago

@kowalski we have to remember the onion addresses of all the members in the team somewhere, correct? I suppose that's in orbitdb.

Just to make sure, we don't want to forget stuff that's useful, since that user could—at some point in the future—be the only online user. So when we're connecting, we want to try everybody until we reach a few folks.

kowalski commented 3 years ago

I think the onion address will simply be the CN in certificate for the user identity. And all of these will be added to user registry of the community.

What I'm talking about in previous message is the address book in memory of libp2p instance. I think it's causing a lot of connecftions to non-existint addresses. It's fine to temporary forget addresses of offline people from there. Once these people come online they will make connections and "remind" network about themselves

holmesworcester commented 3 years ago

Gotcha. Okay, that sounds fine as long as an offline user always has a full list to connect to when they return.

On May 14, 2021, at 12:25 PM, Marek Kowalski @.***> wrote:

I think the onion address will simply be the CN in certificate for the user identity. And all of these will be added to user registry of the community.

What I'm talking about in previous message is the address book in memory of libp2p instance. I think it's causing a lot of connecftions to non-existint addresses. It's fine to temporary forget addresses of offline people from there. Once these people come online they will make connections and "remind" network about themselves

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ZbayApp/zbay/issues/827#issuecomment-841350276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUFLSRIRKM5DG4JGJ3G43TNVFIXANCNFSM444WC52Q.