search

TrySound / postcss-easy-import

PostCSS plugin to inline @import rules content with extra features
MIT License
201 stars 25 forks source link

Dynamic resolve - 2 #13

Closed toomuchdesign closed 7 years ago

toomuchdesign commented 7 years ago

Here is the rebased PR of my previous dynamic resolve PR #7. It's all the same except for a dependency update.

@simonsmith, if you decide to make dynamic resolve the default behaviour, you can easlily start for here just changing a couple of if statements in index file.

In order to test the dynamic resolve feature, I run both resolve-module and resolve-glob tests twice: with and without dynamic resolve.

Happy to support you if you have any doubt! Greetings!

simonsmith commented 7 years ago

This is great. Thanks @toomuchdesign

I'm leaning towards to making it default behaviour. I think if people reported cases where it got in the way we could allow them to opt out with an option at a later date.

It might make the tests simpler too.

I'll take a look at this tomorrow and will be sure to get your feedback before merging.

simonsmith commented 7 years ago

Closing in favour of #14

Thanks for this though @toomuchdesign :)