search

TrySound / rollup-plugin-eslint

This plugin in migrated https://github.com/rollup/plugins/tree/master/packages/eslint
MIT License
61 stars 17 forks source link

Ignore checking order #37

Open N0NamedGuy opened 4 years ago

N0NamedGuy commented 4 years ago

My project depends indirectly on an older package (in my specific case rollup-plugin-node-builtins) that ships with an .eslintrc file. This shipped .eslintrc uses a deprecated config (ecmaFeature), and that makes eslint throw a deprecation warning.

Besides opening a ticket on rollup-plugin-node-builtins, I have no control over .eslintrc files that other projects may include.

This deprecation warning is thrown when rollup-plugin-eslint asks ESLint's CLIEngine if the file is ignored:

https://github.com/TrySound/rollup-plugin-eslint/blob/8c5aba303a9b0af4bd8bc61454a0e14581e1db0e/index.js#L36

Now if the ignore checking was done by rollup-plugin-eslint first, and THEN query ESLint, it would grant me control over on what actually eslint gets to touch or not.

Thank you for attention. Pull request coming soon.

tschoartschi commented 4 years ago

We encountered the exact same problem... I think also others discovered this issue (for example here: https://github.com/TrySound/rollup-plugin-eslint/issues/40#issuecomment-581459238)

@TrySound what do you think about the pull-request (https://github.com/TrySound/rollup-plugin-eslint/pull/38)? It would be great to get some feedback 🙂maybe you could spend some of your time and let us know 😉thanks a lot for your work on the plugin