search

TrystanScottLambert / WAVES_mock_catalogue_generator

Code to build mock catalogues for the upcoming WAVES survey.
MIT License
1 stars 0 forks source link

Inputs handling #2

Closed TrystanScottLambert closed 3 weeks ago

TrystanScottLambert commented 1 month ago

I'm not a huge fan of how the imports are currently handled. I think what might be better is some input.json file or something like this. That'll be easier to record in the versioning.

TrystanScottLambert commented 4 weeks ago

I've decided that we should use the YAML files for processing the inputs since they are very human readable. They aren't part of the standard library but the packages we are already using seem to have it as a requirement so we essentially get this for free.

I've started a new branch where the I've included a load module that also handles the input validation. I've also updated the main functions in the read module to handle a single config file instead of multiple input files. Tests will need to be updated to include this new functionality.

I'll merge the the branch once tests have been updated for read and tests are written for the load module.

TrystanScottLambert commented 3 weeks ago

We've included YAML files as our input and have implemeted a config object that functions now read. See the YAML branch merge #6