I have phantom lights in my world

ninn commented 8 months ago

Describe the bug

Hi. Hope this is the right way to report a (?) bug.

I used your dynlight mod over several months the last year, currently it is deinstalled.

Every now and then, I see phantom lights, where no lightsource should be. Probably where I dropped torches on the ground, but I can not be sure. I can see those spots on the ground, with lightlevels above 0 and no light emiting sources nearby.

I can not get rid of them, whatever I try. They appear in farms I built and it is rather annoying, because I found no way to remove them several month in.

Can you help me removing those lightsources? Is there a command to run and get rid of those phantom lights?

Thanks in advance, John

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

Tschipcraft commented 8 months ago

Thank you for the bug report, yes there are these three commands you could try to run in order:

execute as @e[type=minecraft:marker,tag=ts.dl.light] at @s if block ~ ~ ~ minecraft:light[waterlogged=true] run fill ~ ~ ~ ~ ~ ~ minecraft:water replace light
execute as @e[type=minecraft:marker,tag=ts.dl.light] at @s if block ~ ~ ~ minecraft:light[waterlogged=false] run fill ~ ~ ~ ~ ~ ~ minecraft:air replace light
kill @e[type=minecraft:marker,tag=ts.dl.light]

These are the ones also listed in the wiki. However, I'm not sure if this will fix your problem, since stray light blocks should be removed automatically when Dynamic Lights is installed.

What version of Dynamic Lights did you use when this happened?

ninn commented 8 months ago

The last version I used on my server was 1.7.1, not sure when the stray lights appeared, but I probably encountered the first ones around 6 month ago when I started benchmarking all my datapacks.

Thanks so much for the commands! I was unable to find these commands/information on the wiki, I tried locating those several times; I still can not locate them there.

If you are interested, I can whitelist you on the server. But I guess that is not too interesting for you, - but you can have a look yourself if you want to; we are in the same timezone.

I will create a backups now and wait, locating some stray lights and taking notes.

Tschipcraft commented 8 months ago

I see that's why I wanted to ask, since 6 months ago only v1.6 was out and maybe updating to v1.7 or v1.7.1 could have been the issue. I'll take a look at that.

Whitelisting me isn't really needed, if the commands happen to not work, the marker entities won't be there either for me to look at, but thanks for the offer.

The commands are hidden under a dropdown, the last sentence on the page Home. Admittedly, they are pretty hidden 😅

ninn commented 8 months ago

the commands did not remove the lights. I will try to investigate further, and report back.

Tschipcraft commented 8 months ago

That's a shame, sorry for the issues. Since the commands don't work, the marker entities got removed somehow so the only option is to remove them manually by hand (you need to hold a light block in order to see them /give @s minecraft:light) or use a world editor like e.g. Amulet to remove them in bulk. If you want I could do this for you (since it's kinda my project's fault it even happened)

ninn commented 8 months ago

Thanks a lot for sharing that valueable information! I will try that out, thanks!

Do not feel bad. I really enjoyed the plugin a lot! And it is probably my fault, since I enabled/installed/disabled/removed the plugins out of order and tested everything possible. And I did that a lot with your plugin, because I was testing a lot with it.

I will report back! Happy easter! :)

ninn commented 8 months ago

I have deleted most of the stray lights.

I was unable to see the lights, with or without lightblock in my hands. but luckily I got carpetmod, and followed the lightlevel till I got to a lightlevel of 14, which was basicly the illuminated/shining block. It was like playing windows minesweeper, looking for the bomb. Placed a block there, - bam! - lights out.

observation: Most of the light blocks where above ground. I expected them to be the torches I threw, but most of them where 4-10 blocks up (or down, in the case of my netherroof-farm). This made me think, that they were leftofters of elytra-flybys while holding a torch.

I got rid of most offending lights, and if I ever find more, I know exactly how to delete them!

Thanks so much for your (debugging) help and explanations! And for the datapack itself of course!

Tschipcraft commented 8 months ago

That's interesting, I do not use light blocks with level 14, only 6, 9 and 15. So if the light levels only go to 14 and no light block is near when holding the light item, this might have been the blocks around the dynamic lights not updating in time and not loosing their light values.. So I guess the problem never was my project but just Minecraft's light engine..?

Anyway, glad it worked, happy Easter to you as well!