search

Tschipcraft / dynamiclights

Burning entities/items such as torches or lanterns emit light!
https://tschipcraft.ddns.net/dynamiclights.html
Other
23 stars 1 forks source link

Incompatible with Minecraft 1.21 #29

Closed rock3tsprocket closed 4 months ago

rock3tsprocket commented 6 months ago

Describe the bug

everything lights up

Steps to reproduce

1: install the datapack in a world for 24w18a (idk if the mod also does that) 2: hold/drop anything

Expected behavior

for only the stuff listed in the readme to light up

Additional context

No response

Tschipcraft commented 6 months ago

Thanks for the report. I will however first focus on compatibility for 1.20.5/1.20.6.

sdy623 commented 6 months ago

Thanks for the report. I will however first focus on compatibility for 1.20.5/1.20.6.

1.20.6 made a huge change on JAVA from 17 to 21, and its release date is close to 24w18a, so It is a good idea that made the compatibility fix on 1.20.6 first.

Tschipcraft commented 6 months ago

Well, the Java change isn't really that big of a deal, at least for this project. It's the new item components that make the pack incompatible.

BrailleBennett commented 6 months ago

Did fixing it for 1.20.6 automagically fix it for 1.21?

Tschipcraft commented 6 months ago

It definitely helped, but some parts are for sure not compatible with the latest snapshot yet

Tschipcraft commented 4 months ago
Why have you only started updating now? > My last exam for this semester was on 07/03/2024. I hope it's understandable that I focused on my exam phase first.

Support for Snapshot 24w18a was added with this commit (forgot to link): https://github.com/Tschipcraft/dynamiclights/commit/2ea659d1ca2cd70eb016cf91dd77fd9cbc17a72d Temporary dev builds for this commit are available here (you need to sign in to be able to download)

Support for Snapshot 24w21a was added with this commit: https://github.com/Tschipcraft/dynamiclights/commit/6a600f98b38154bcff38f0902899e048817f37c5 Temporary dev builds for this commit are available here

Final changes for 1.21 support were added with https://github.com/Tschipcraft/dynamiclights/commit/96a4df7b9da5561e7100a486f202d292aab1c896 and https://github.com/Tschipcraft/dynamiclights/commit/275613d687c8576191142fc277a367f76fd2642a Temporary dev builds are available here Please report any bugs that might have crept in.