search

Tschipcraft / dynamiclights

Burning entities/items such as torches or lanterns emit light!
https://tschipcraft.ddns.net/dynamiclights.html
Other
22 stars 0 forks source link

Incompatible with MCPitanLib in 1.21 #49

Closed GuyFromTheInternet closed 3 weeks ago

GuyFromTheInternet commented 1 month ago

Describe the bug

No response

Steps to reproduce

  1. Install MCPitanLib

Expected behavior

It should work

Additional context

No response

Tschipcraft commented 1 month ago

I ran a quick test in Minecraft 1.20.1 with Dynamic Lights v1.8.3 and MCPitanLib 2.3.3, and it seems to be working just fine. Could you add any additional information to this issue? Please include mod version numbers and your most recent minecraft log.

GuyFromTheInternet commented 1 month ago

1.21 Forgot to mention

Tschipcraft commented 1 month ago

Thanks. I'm not sure what MCPitanLib is doing. Looks like it's using the old version of a tag file located in the old folder format (pre-1.21) and tries to load a dependency of it in the new folder format, which makes absolutely no sense. By the looks of things, the source code of MCPitanLib for 1.21 isn't even available on their GitHub, so there's nothing I can do.

The only warning connected to this: Not all defined tags for registry ResourceKey[minecraft:root / minecraft:entity_type] are present in data pack: dynamiclights:reparse_interactible (reparse_interactible does not exist in the new folder format, but is not normally called. Because of this error, the entity tags fail to load, which ultimately disables the whole data pack since there are no entities to select)

GuyFromTheInternet commented 4 weeks ago

I think the MCPitanLib was moved to https://github.com/Pitan76/MCPitanLib/tree/1.21

Tschipcraft commented 4 weeks ago

Thanks for letting me know, the Modrinth page is still linking to the old repo. I added an issue there to let others know.

Interestingly, Mod Menu is also showing a different mod linking to https://github.com/Pitan76/CompatDatapacks/tree/1.21 (most likely embedded into MCPitanLib), so I'll take a look at that

Tschipcraft commented 3 weeks ago

This has been fixed as of MCPitanLib-2.3.3-fix.1 🎉