Tschipcraft / dynamiclights

Burning entities/items such as torches or lanterns emit light!
https://tschipcraft.ddns.net/dynamiclights.html
Other
23 stars 1 forks source link

Breaks some zero tick pistons #51

Open MrJRBell opened 2 months ago

MrJRBell commented 2 months ago

Describe the bug

When a light emitting item is dropped in the vicinity of a zero tick returning piston, the piston is blocked form activating.

Steps to reproduce

Place a piston with a slime block on it's face, a stone block above the sticky block, a note block above the piston and a glazed terracotta diagonally in front and below the stick piston (or other non stick block that a light emitting item can be dropped on)

Quasi power the piston via the stone block. (for testing, run an observer into the top of the stone block with another note block on its face).

If there is no light emitting item in front of the slime block, the system works fine (press the topmost note block to test). Drop a light emitting item on the glazed terracotta (in front of the slime block) then re-test (press the topmost note block) and the piston will not extend.

Expected behavior

piston fires regardless of item type dropped.

Additional context

No response

Tschipcraft commented 2 months ago

Thank you for the bug report. I believe this is just an issue with my detection system. Right now, it can't handle cases like this correctly:

2024-08-26_22 15 56

It properly identifies the piston chain and doesn't place the light block in front of the slime block, but fails to detect that the stone block is part of the contraption.