Tschipcraft / dynamiclights

Burning entities/items such as torches or lanterns emit light!
https://tschipcraft.ddns.net/dynamiclights.html
Other
23 stars 1 forks source link

Items with NBTs having a light source #61

Closed MrAsgard closed 2 weeks ago

MrAsgard commented 2 weeks ago

Describe the bug

Hi, its DarkAsgard124 but im on a new profile, few months ago i have gotten in contact with you about manualy updating the datapack to 1.21 so it could work for my atlas realm map, well im back again, im trying to use the datapack for 1.21.3, everything works but items with custom NBTs are emitting light source, can you guide me how to fix it manualy so i could push the updated version of the map to the atlas, thank you very much.

Steps to reproduce

no NBT image no NBT!image with NBT image with NBT image

Expected behavior

No response

Additional context

No response

Tschipcraft commented 2 weeks ago

What? I didn't think there would be any major issues when upgrading to 1.21.3. Could you add what NBT you used for the pickaxe? (ps. nice to see you back at it again)

MrAsgard commented 2 weeks ago

What? I didn't think there would be any major issues when upgrading to 1.21.3. Could you add what NBT you used for the pickaxe? (ps. nice to see you back at it again)

Okay now i feel kinda dumb.. totally forgot that pickaxe had hidden enchantment which emitted the light, ive disabled it in settings, sorry for wasting your time.

Tschipcraft commented 2 weeks ago

Ah, no worries