Extreme lag when used in conjunction with Sounds and Sound Physics Remastered

[Fyoncle]

Describe the bug

https://github.com/IMB11/Sounds/issues/68# https://github.com/IMB11/Sounds/issues/77 Read these two issues.

Steps to reproduce

Stated in the previous issues.

Expected behavior

To not lag.

Additional context

No response

[Tschipcraft]

Thank you for the bug report. Make Bubbles Pop produces a lot of bubble_pop sound events when bubble particles pop, so this might be the underlying issue here, as the sound physics mod obviously has to do quite a lot more work for them than vanilla. Turning down the bubble pop volume in the config (added in v0.3.0) might solve this issue. I say might, because atm the sound events are still created with volume set to 0.

I'm not sure what role the Sounds mod plays in this though... Could be that it changes the sound system in some way that makes it performs worse on some systems?

[Fyoncle]

I tried to close specific things in config already, but didnt help. If you want more information Sounds mod 0.9.0 doesn't cause this issue, after it updated to 1.0.1 or something it started happening.

[Fyoncle]

Also reported this to the Sound Physics Remastered, which is he said its your mod's problem https://github.com/henkelmax/sound-physics-remastered/issues/232

[Tschipcraft]

Interesting, I'll take a look at this

[Tschipcraft]

I did the cow test mentioned in the linked issues in Fabric 1.20.1:

Test 1:

• Sounds 0.9.0
• Make Bubbles Pop v0.3.0
• Sound Physics 1.4.5

No issues, fps is stable

Test 2:

• Sounds 1.1.0
• Make Bubbles Pop v0.3.0
• Sound Physics 1.4.5

Fps is horrible, problem disappears when bubble pop volume is set to 0

Test 3:

• Sounds 1.1.0
• Make Bubbles Pop v0.2.0
• Sound Physics 1.4.5

Same as test 2

So, I'm guessing the underlying issue is caused by the Sounds mod

[Fyoncle]

I did the cow test mentioned in the linked issues in Fabric 1.20.1: ... (Edit: trimmed quote)

He said theres no mixin conflicts or anything with your mod, and refused to fix it so i am still not sure.

[Tschipcraft]

I found that I can reproduce the low fps when chaining four command blocks together, each with the command

playsound minecraft:block.stone.break ambient @a

Sound Physics 1.4.5 and Sounds 1.1.0:

Sound Physics 1.4.5 and Sounds 0.9.0:

I'll post this over on the Sounds issue

[Fyoncle]

I found that I can reproduce the low fps when chaining four command blocks together, each with the command

playsound minecraft:block.stone.break ambient @a

Sounds 1.1.0:

Sounds 0.9.0:

I'll post this over on the Sounds issue

Thank you for your insanely detailed tests that i cannot even imagine lmao, i hope IMB11 can reproduce these issues and fix it.

[Fyoncle]

Uh so, do you have any idea to fix that

[Fyoncle]

@Tschipcraft i forgot to tag :v

[Tschipcraft]

I added a comment there

For anyone too lazy to look at the other issue

Make Bubbles Pop increases the bubble particle lifetime a bit compared to vanilla to allow the bubbles to reach the water surface more often. Since Guardians produce a lot of bubbles when they swim around, the particle count increases quite quickly, causing low fps. I might be able to reduce the particle count they produce in a future update. For now, bubble lifetime can also be decreased in the settings (related to https://github.com/Tschipcraft/make_bubbles_pop/issues/4#issuecomment-1758593635)

[Fyoncle]

@Tschipcraft I removed sounds, and your mod is the reason of the guardian beam lag, so Sounds is not related to this issue.

[Tschipcraft]

Well yes, that's what I wrote in my comment

[Fyoncle]

Well yes, that's what I wrote in my comment

Wait no, none of these 3 mods is the reason, i also get that issue with all of that 3 combo disabled, theres something wrong... theres a 4th incompatibility...

[Tschipcraft]

So it happens without Make Bubbles Pop is what you're saying?

[Fyoncle]

So it happens without Make Bubbles Pop is what you're saying?

Without sounds, without make bubbles pop, without sound physics remastered.

[Fyoncle]

So it happens without Make Bubbles Pop is what you're saying?

Now it doesn't happen, i think problem is at the "ocean monument" instead of the beams itself.

[Fyoncle]

Nvm this doesn't happen places with no water, but if you also place water on somewhere else it also doesn't happen, but if you try it on a ocean biome, it happens, on monuments too, thats too interestingn and idk what triggers that.

[Fyoncle]

Mod called https://modrinth.com/mod/lambdynamiclights is the cause of everything.

[Fyoncle]

Theres 5th incompatibility too...

[Tschipcraft]

Mod called modrinth.com/mod/lambdynamiclights is the cause of everything.

I have a dynamic lights mod as well

[Tschipcraft]

Anyway, since this has nothing to do with Make Bubbles Pop anymore, I think we can close this, right?

[Fyoncle]

Anyway, since this has nothing to do with Make Bubbles Pop anymore, I think we can close this, right?

Ill make one more test after finding the 5th mod, i am currently so close to finding it with Binary Searching, ill talk to you back in 30 mins if that's fine?

[Fyoncle]

Both of my folders does not give any result, but when mixed they do.

So theres 6th incompatibility. Searching!

[Fyoncle]

Theres tens of combinations, almost impossible to find 2 conflicting mods Have any idea?

[Tschipcraft]

Nope

[Fyoncle]

Mod called modrinth.com/mod/lambdynamiclights is the cause of everything.

I have a dynamic lights mod as well

Your mod is causing the same chaos. FPS Falling to around 4 or 6 when guardians hit beams. When all the dynamic light mods disabled, everythings fine.

[Tschipcraft]

My dynamic lights mod doesn't touch guardians or their beam at all, so I really don't think that's the issue there. Anyhow, this has nothing to do with Make Bubble Pop anymore. I will close this issue as resolved. If you want me to fix the dynamic lights issue, head over to the other repo and create a new bug report, including what other mods you are using so that I can actually debug this