search

Tschipp / CarryOn

Carry On mod for Minecraft
GNU Lesser General Public License v3.0
85 stars 48 forks source link

[Fabric 1.19.2 Bug] CarryOn does not respect FLAN land claims #487

Open itsdinkd opened 1 year ago

itsdinkd commented 1 year ago

Expected Behavior

Not to allow players to pick up blocks or mobs in claims made by other players.

Actual Behavior

Players with no permissions to other players claim can pick up. ie; steal chests.

Steps to Reproduce

  1. Download Flan and Carryon
  2. Have player claim a land
  3. Enter that players land, and pick up whatever you want

Version of Minecraft, Carry On, Forge/Fabric

1.19.2 Fabric

Screenshots encouraged

image

Tschipp commented 1 year ago

See my comment on https://github.com/Flemmli97/Flan/issues/235

itsdinkd commented 1 year ago

See my comment on Flemmli97/Flan#235

thats odd because it has Break is blocked by default for visitor groups (basically random players). here below you can though identify a blacklist. image

is there anything I can add here? image

itsdinkd commented 1 year ago

i wonder if i can add c:carryon:block-whitelist to interactBlockEntityTagBlacklist array would help prevent it?

Edit: crap, I figured there would be entries in that tag, but apparently I would have to add every thing in it. this wont work.

Edit 2: I was thinking about adding just every block tag like needs_stone_pickaxe but apparently those blacklist keys make it so it 'ignores' permissions, basically, allowing you to override the check to stop you. damn. the dev needs to implement something but they're MIA., this sucks.

Tschipp commented 1 year ago

I don't really know how to help further here. I just tested myself, and if the Break Event is cancelled by a mod, the block is not picked up.