Unclear error message for making a reservation

[Tsenrae]

Steps to reproduce:

1. rsv 1 d/2021-02-29 t/1800 p/8

Expected: Error message saying that the date is invalid as 2021 is a leap year.

Actual: Unclear error message only saying that date is invalid.

[nus-se-bot]

Team's Response

This bug report is invalid as 2021 is not a leap year.

Furthermore, this error message clearly states that the date "2021-02-29" is invalid.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: I acknowledge my mistake in my bug description, Error message saying that the date is invalid as 2021 is a leap year. The correct description should be Error message saying that date is invalid as 2021 is NOT a leap year. However, this does not invalidate my bug as the error message given is still unclear.

Following your screenshot, you are arguing that the date 2021-02-29 is invalid, hence it should be taken as a format error, and hence the error message given is correct. However, this argument is incorrect as the reason why 2021-02-29 is an invalid input is *not** because Februrary dosen't have 30 days, but because for the specific year 2021, February 29 does not exist as 2021 is not a leap year. Thus, it is insufficient to just say that 2021-02-29 is a format error as if the date given is 2020-02-29 instead, the date will be accepted as 2020 is a leap year, and hence February 29 exists for that year. Thus, you would not be giving sufficient information to the user by simply saying 2021-02-29 is in the wrong format, as this might lead the user to misinterpret it and think that February 29 would always be an incorrect date regardless of the year. The correct error message should be more clear, saying that 2021-02-29 is an invalid date as 2021 is a leap year. This would then provide a very clear message to the user as to exactly why the certain date is invalid, and leave no room for misinterpretation.

---

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is a functionality bug, not a feature flaw as in the requirements for functionality bugs, as shown in the screenshot below taken from the 2103T website, it includes the case where the error message does not match the error, which is exactly the case of this bug here. 

---

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]

---