Tsenrae / pe

0 stars 0 forks source link

Bug with adding duplicate names #12

Open Tsenrae opened 6 months ago

Tsenrae commented 6 months ago

Steps to reproduce:

  1. add n/Alex Yeoh p/87438807 e/alexyeoh@example.com a/Blk 30 Geylang Street 29
  2. add n/Alex yeoh p/87438807 e/alexyeoh@example.com a/Blk 30 Geylang Street 29

Expected: Error message as the names Alex Yeoh and Alex yeoh are the same

Actual: Command passes and duplicate persons are shown in the UI.

Screenshot 2024-04-19 at 5.07.25 PM.png

nus-se-bot commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name duplication check is not case insensitive

image.png

Although names with same characters but different cases should be considered as same names but they can be still added to the list at the same time.


[original: nus-cs2103-AY2324S2/pe-interim#4678] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

There exists names which require different cases to differentiate between them, due to cultural nuances. For example, "Bryan De La Cruz" is different from "Bryan de la Cruz"

We decided to accommodate these cases as well.

Thus, this is the expected behavior of our app.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** For the example you gave in the screenshot, they clearly are 2 totally different names, the first person's name is `Bryan De La Cruz`, while the second person's name is `Cacho de la Cruz`. The `d` being different cases is **not** the only difference in their names, hence this is an invalid justification as to why the duplicate name check being case insensitive should be accepted, as the names I gave in my bug, `Alex Yeoh`, and `Alex yeoh` have no difference besides the `y` being of a different case. Thus, your claim that this is the expected behaviour of your app is wrong. If you did want to argue that there exists names which require different cases to differentiate them due to cultural nuances, and gave an actual **valid** example of such a case, this would still not invalidate my bug as you did not state this feature in the UG. An average user would definitely be confused as to why they are able to add the same names `Alex Yeoh` and `Alex yeoh` given that you clearly stated in the UG that **duplicate names are not allowed**(see screenshot below), hindering their user experience. If intentions were clear, you would have stated in the UG that 'due to cultural nuances, we do not check for case sensitivity in duplicate names` and provide the relevant justifications. Furthermore, as per the screenshot below taken from the 2103T website, they clearly state that duplicate names with different cases are considered **different names**, and that a warning should be given in such cases to allow the user to decide on what to do. This bug falls exactly under the case mentioned in the screenshot, and it is clear that it should be considered a type.FeatureFlaw. ![photo_2024-04-24_02-43-33.jpg](https://raw.githubusercontent.com/Tsenrae/pe/main/files/d869d2a9-c4ea-48b9-8850-dda017aa5cf3.jpg)